lkml.org 
[lkml]   [2010]   [Jun]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: bnx2 fails to compile on parisc because of missing get_dma_ops()
    From
    On Wed, 16 Jun 2010 20:13:49 -0500
    James Bottomley <JBottomley@Novell.com> wrote:

    > I'm not quite sure whose fault this one is.
    >
    > However, this code in bnx2.c:
    >
    > if (!get_dma_ops(&pdev->dev)->sync_single_for_cpu) {
    > next_rx_buf =
    > &rxr->rx_buf_ring[
    > RX_RING_IDX(NEXT_RX_BD(sw_cons))];
    > prefetch(next_rx_buf->desc);
    > }
    >
    > Looks remarkably fragile: what exactly is it trying to do?
    >
    > The commit that causes the problem:
    >
    > commit a33fa66bcf365ffe5b79d1ae1d3582cc261ae56e
    > Author: Michael Chan <mchan@broadcom.com>
    > Date: Thu May 6 08:58:13 2010 +0000
    >
    > bnx2: Add prefetches to rx path.
    >
    > Looks fairly innocuous by the description.
    >
    > Should parisc have a get_dma_ops()? We don't need one because our dma
    > ops are per platform not per bus.

    Shouldn't. Only the architectures that use
    include/dma-generic/dma-mapping.common.h need to have get_dma_ops().

    Using include/dma-generic/dma-mapping.common.h for parisc is not a bad
    idea though.


    \
     
     \ /
      Last update: 2010-06-17 14:17    [W:0.049 / U:0.340 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site