lkml.org 
[lkml]   [2010]   [Jun]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[PATCH] x86: OLPC: use pr_debug() for EC commands

    Unconditionally printing EC debug messages was helpful when we were actually
    debugging the EC, but during normal operation it can get pretty annoying.
    Using pr_debug allows us finer-grained control.

    (Richard, please yell if this shouldn't be done.)

    Signed-off-by: Andres Salomon <dilinger@queued.net>
    ---
    arch/x86/kernel/olpc.c | 8 +++-----
    1 files changed, 3 insertions(+), 5 deletions(-)

    diff --git a/arch/x86/kernel/olpc.c b/arch/x86/kernel/olpc.c
    index 1566052..f5ff390 100644
    --- a/arch/x86/kernel/olpc.c
    +++ b/arch/x86/kernel/olpc.c
    @@ -142,7 +142,7 @@ restart:
    * The OBF flag will sometimes misbehave due to what we believe
    * is a hardware quirk..
    */
    - printk(KERN_DEBUG "olpc-ec: running cmd 0x%x\n", cmd);
    + pr_devel("olpc-ec: running cmd 0x%x\n", cmd);
    outb(cmd, 0x6c);

    if (wait_on_ibf(0x6c, 0)) {
    @@ -159,8 +159,7 @@ restart:
    " EC accept data!\n");
    goto err;
    }
    - printk(KERN_DEBUG "olpc-ec: sending cmd arg 0x%x\n",
    - inbuf[i]);
    + pr_devel("olpc-ec: sending cmd arg 0x%x\n", inbuf[i]);
    outb(inbuf[i], 0x68);
    }
    }
    @@ -173,8 +172,7 @@ restart:
    goto restart;
    }
    outbuf[i] = inb(0x68);
    - printk(KERN_DEBUG "olpc-ec: received 0x%x\n",
    - outbuf[i]);
    + pr_devel("olpc-ec: received 0x%x\n", outbuf[i]);
    }
    }

    --
    1.5.6.5



    \
     
     \ /
      Last update: 2010-06-17 05:21    [W:5.653 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site