lkml.org 
[lkml]   [2010]   [Jun]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5/9] oom: cleanup has_intersects_mems_allowed()
    Date

    Now has_intersects_mems_allowed() has own thread iterate logic, but
    it should use while_each_thread().

    It slightly improve the code readability.

    Reviewed-by: Minchan Kim <minchan.kim@gmail.com>
    Signed-off-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
    ---
    mm/oom_kill.c | 8 ++++----
    1 files changed, 4 insertions(+), 4 deletions(-)

    diff --git a/mm/oom_kill.c b/mm/oom_kill.c
    index 541a59b..b27db90 100644
    --- a/mm/oom_kill.c
    +++ b/mm/oom_kill.c
    @@ -46,10 +46,10 @@ static DEFINE_SPINLOCK(zone_scan_lock);
    * shares the same mempolicy nodes as current if it is bound by such a policy
    * and whether or not it has the same set of allowed cpuset nodes.
    */
    -static bool has_intersects_mems_allowed(struct task_struct *tsk,
    +static bool has_intersects_mems_allowed(struct task_struct *p,
    const nodemask_t *mask)
    {
    - struct task_struct *start = tsk;
    + struct task_struct *tsk = p;

    do {
    if (mask) {
    @@ -69,8 +69,8 @@ static bool has_intersects_mems_allowed(struct task_struct *tsk,
    if (cpuset_mems_allowed_intersects(current, tsk))
    return true;
    }
    - tsk = next_thread(tsk);
    - } while (tsk != start);
    + } while_each_thread(p, tsk);
    +
    return false;
    }
    #else
    --
    1.6.5.2




    \
     
     \ /
      Last update: 2010-06-17 03:57    [W:0.023 / U:29.908 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site