lkml.org 
[lkml]   [2010]   [Jun]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 3/3] cxgb4i_v4.3 : main driver files
    On 06/07/2010 11:59 PM, Rakesh Ranjan wrote:
    > From: Rakesh Ranjan<rakesh@chelsio.com>
    >
    >
    > Signed-off-by: Rakesh Ranjan<rakesh@chelsio.com>
    > ---
    > drivers/scsi/cxgbi/cxgb4i.h | 175 +++++
    > drivers/scsi/cxgbi/cxgb4i_ddp.c | 653 ++++++++++++++++
    > drivers/scsi/cxgbi/cxgb4i_init.c | 317 ++++++++
    > drivers/scsi/cxgbi/cxgb4i_offload.c | 1409 +++++++++++++++++++++++++++++++++++
    > 4 files changed, 2554 insertions(+), 0 deletions(-)
    > create mode 100644 drivers/scsi/cxgbi/cxgb4i.h
    > create mode 100644 drivers/scsi/cxgbi/cxgb4i_ddp.c
    > create mode 100644 drivers/scsi/cxgbi/cxgb4i_init.c
    > create mode 100644 drivers/scsi/cxgbi/cxgb4i_offload.c
    >

    Do you think you can look through this patch and identify the places
    where you basically just copied a cxgb3i function or copied it but
    renamed some stuff and then move these type of things to the lib patch?

    A lot of the scatter list stuff for example looks the same in each driver.

    ddp_find_unused_entries - cxgb4i_ddp_find_unused_entries
    ddp_unmark_entries - cxgb4i_ddp_unmark_entries
    cxgb3i_ddp_find_page_index - cxgb4i_ddp_find_page_index
    cxgb3i_ddp_adjust_page_table - cxgb4i_ddp_adjust_page_table
    ..... (lots of the ddp code looks duplicated).

    The *_offload.c code looks the same.


    \
     
     \ /
      Last update: 2010-06-17 00:19    [W:0.019 / U:58.628 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site