Messages in this thread | | | Date | Wed, 16 Jun 2010 15:58:01 -0400 | From | Valerie Aurora <> | Subject | Re: [PATCH] d_ino considered harmful |
| |
On Wed, Jun 16, 2010 at 09:10:42PM +0200, Arnd Bergmann wrote: > On Wednesday 16 June 2010 20:59:13 Valerie Aurora wrote: > > @@ -91,7 +91,9 @@ static int fillonedir(void * __buf, const char * name, int namlen, loff_t offset > > > > if (buf->result) > > return -EINVAL; > > - d_ino = ino; > > + /* Use of d_ino without st_dev is always buggy. */ > > + d_ino = 0; > > + > > if (sizeof(d_ino) < sizeof(ino) && d_ino != ino) { > > buf->result = -EOVERFLOW; > > return -EOVERFLOW; > > Isn't this just the path taken by sys_oldreaddir? > > Glibc (at least on my box) translates all user calls to readdir into > sys_getdents or sys_getdents64, so I think you'd also need to change > filldir() and filldir64() for your testing.
You're right. I changed both code paths in the new version, and actually tested this time.
Thanks,
-VAL
| |