lkml.org 
[lkml]   [2010]   [Jun]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 0/5] Fix set but unused variable warnings
    On Wed, Jun 16, 2010 at 03:52:58PM +1000, Julian Calaby wrote:
    > Given that patches 3, 4 and 5 seem to be a cases of missing error
    > handling, (3 and 4 in particular seem to be breaking things rather
    > than fixing them) in my humble opinion, I think this set needs some
    > work and discussion.
    >
    > Justin, maybe you'd be better off posting the actual error messages
    > (split up by subsystem) and letting the lists discuss them, rather
    > than posting patches which are obviously wrong. (like the ones I've
    > pointed out)

    My first impression of patch 5 was "that can't be right", but upon review,
    I concluded that was the best solution. If we return the PTR_ERR, this
    is going to confuse every user of scsi_host_alloc who are currently only
    checking for NULL.

    --
    Matthew Wilcox Intel Open Source Technology Centre
    "Bill, look, we understand that you're interested in selling us this
    operating system, but compare it to ours. We can't possibly take such
    a retrograde step."


    \
     
     \ /
      Last update: 2010-06-16 13:11    [W:0.020 / U:0.452 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site