Messages in this thread | | | Date | Tue, 15 Jun 2010 16:01:32 +0200 | From | Jan Kara <> | Subject | Re: [PATCH] [17/23] EXT3: Fix set but unused variables |
| |
> On Thu, Jun 10, 2010 at 01:10:53PM +0200, Andi Kleen wrote: > > Index: linux-2.6.35-rc2-gcc/fs/jbd/recovery.c > > =================================================================== > > --- linux-2.6.35-rc2-gcc.orig/fs/jbd/recovery.c > > +++ linux-2.6.35-rc2-gcc/fs/jbd/recovery.c > > @@ -283,12 +283,10 @@ int journal_recover(journal_t *journal) > > int journal_skip_recovery(journal_t *journal) > > { > > int err; > > - journal_superblock_t * sb; > > > > struct recovery_info info; > > > > memset (&info, 0, sizeof(info)); > > - sb = journal->j_superblock; > > Oops, spoke too soon. This will cause a compile error if > CONFIG_JBD_DEBUG is defined. > > The following pesudo-patch is required: > > #ifdef CONFIG_JBD_DEBUG > - int dropped = info.end_transaction - be32_to_cpu(sb->s_sequence); > + int dropped = info.end_transaction - > + be32_to_cpu(journal->j_superblock->s_sequence); > #endif I have merged the patch with your fix to my tree.
Honza -- Jan Kara <jack@suse.cz> SuSE CR Labs
| |