lkml.org 
[lkml]   [2010]   [Jun]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 08/12] vmscan: Setup pagevec as late as possible in shrink_inactive_list()
    On Mon, Jun 14, 2010 at 12:17:49PM +0100, Mel Gorman wrote:
    > /*
    > + * TODO: Try merging with migrations version of putback_lru_pages
    > + */
    > +static noinline_for_stack void putback_lru_pages(struct zone *zone,
    > + struct zone_reclaim_stat *reclaim_stat,
    > + unsigned long nr_anon, unsigned long nr_file,
    > + struct list_head *page_list)
    > +{

    I hate to nitpick on this, but with noinline_for_stack a prototype
    really is unreadbale unless the function identifier goes to the next
    line. Compare the one above with:

    static noinline_for_stack void
    putback_lru_pages(struct zone *zone, struct zone_reclaim_stat *reclaim_stat,
    unsigned long nr_anon, unsigned long nr_file,
    struct list_head *page_list)

    > -static unsigned long shrink_inactive_list(unsigned long nr_to_scan,
    > +static noinline_for_stack unsigned long shrink_inactive_list(unsigned long nr_to_scan,
    > struct zone *zone, struct scan_control *sc,
    > int priority, int file)

    Same here, just even worse due to the spill over ove 80 characters.



    \
     
     \ /
      Last update: 2010-06-15 12:49    [W:4.077 / U:0.140 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site