lkml.org 
[lkml]   [2010]   [Jun]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [RFC,PATCH 1/2] Add a common struct clk
    Hello,

    > And arch/arm/plat-s3c/clock.c has the following comment:
    > |/* We originally used an mutex here, but some contexts (see resume)
    > | * are calling functions such as clk_set_parent() with IRQs disabled
    > | * causing an BUG to be triggered.
    > | */
    > |DEFINE_SPINLOCK(clocks_lock);
    I wonder why it's needed to reparent clocks during resume. And where
    exactly IRQs are disabled. Hmm, this comment was initially introduced
    by v2.6.28-rc7-180-gc3391e3, its commit log talks about cpufreq, not
    resume.

    Ben (Dooks): Is this still relevant?

    Best regards
    Uwe

    --
    Pengutronix e.K. | Uwe Kleine-König |
    Industrial Linux Solutions | http://www.pengutronix.de/ |
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2010-06-14 11:37    [W:4.031 / U:0.208 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site