| Date | Mon, 14 Jun 2010 17:55:51 -0400 | From | Rik van Riel <> | Subject | Re: [PATCH 12/12] vmscan: Do not writeback pages in direct reclaim |
| |
On 06/14/2010 07:17 AM, Mel Gorman wrote:
> diff --git a/mm/vmscan.c b/mm/vmscan.c > index 4856a2a..574e816 100644 > --- a/mm/vmscan.c > +++ b/mm/vmscan.c > @@ -372,6 +372,12 @@ int write_reclaim_page(struct page *page, struct address_space *mapping, > return PAGE_SUCCESS; > } > > +/* kswapd and memcg can writeback as they are unlikely to overflow stack */ > +static inline bool reclaim_can_writeback(struct scan_control *sc) > +{ > + return current_is_kswapd() || sc->mem_cgroup != NULL; > +} > +
I'm not entirely convinced on this bit, but am willing to be convinced by the data.
-- All rights reversed
|