Messages in this thread | | | Date | Mon, 14 Jun 2010 14:14:47 -0700 | From | Andrew Morton <> | Subject | Re: [PATCH v2] panic: keep blinking in spite of long spin timer mode |
| |
On Fri, 11 Jun 2010 07:31:13 +0900 TAMUKI Shoichi <tamuki@linet.gr.jp> wrote:
> Hello, > > On Wed, 9 Jun 2010 15:15:52 -0700 Andrew Morton wrote: > > > Morse code? Kidding? > > I'm sorry, I'm confusing you. > > > Sorry, no. Nobody who uses this feature will know what what > > "words per minute" means. It's nutty! > > That is just a strained interpretation where the measure of the > blinking speed comes from. The description of "words per minute" > has already disappeared in the latest patch. > > > Please remind me why we're making this configurable at all. Can't we > > just hardwire the thing to 1Hz or something? Add an > > im_using_a_hypervisor boot option or something, if necessary? > > For now, gta02_panic_blink(), one of panic_blink() users, expects a > 10Hz call rate. IOW, it blinks at 5Hz (i.e. panicblink=36). I think > that the desirable blinking speed is different according to devices. >
gta02_panic_blink() simply toggles a gpio output. It's trivial to convert that function to implement whatever behaviour we decide upon. Err, in fact your patch already does that.
I still don't think we should have a kernel boot option for this - it just doesn't seem useful enough. Can we please just hard-wire the blinking frequency? And once we've done that, we don't have to jump through hoops with this "wpm" thing. We can use Hz.
| |