lkml.org 
[lkml]   [2010]   [Jun]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 1/8]reiserfs:stree.c Fix variable set but not used.
    On 13:26 Mon 14 Jun     , Justin P. Mattock wrote:
    > @@ -617,8 +616,7 @@ int search_by_key(struct super_block *sb, const struct cpu_key *key, /* Key to s
    >
    > pathrelse(search_path);
    >
    > - right_neighbor_of_leaf_node = 0;
    > -
    > +

    This hunk introduces whitespace on the empty line, which is not cool.

    > /* With each iteration of this loop we search through the items in the
    > current node, and calculate the next current node(next path element)
    > for the next iteration of this loop.. */
    > @@ -695,8 +693,7 @@ int search_by_key(struct super_block *sb, const struct cpu_key *key, /* Key to s
    > starting from the root. */
    > block_number = SB_ROOT_BLOCK(sb);
    > expected_level = -1;
    > - right_neighbor_of_leaf_node = 0;
    > -
    > +

    Here, too.

    Most of the patches in this series have similar issues.

    --
    Nick Bowler, Elliptic Technologies (http://www.elliptictech.com/)


    \
     
     \ /
      Last update: 2010-06-14 22:51    [W:0.022 / U:0.204 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site