Messages in this thread |  | | | Date | Mon, 14 Jun 2010 09:42:52 -0400 | | From | tytso@mit ... | | Subject | Re: FIGETBSZ ioctl conflict |
| |
On Mon, Jun 14, 2010 at 02:36:52PM +0200, Johannes Stezenbach wrote: > (forgot to add lkml to Cc) > > On Mon, Jun 14, 2010 at 01:02:52PM +0200, Johannes Stezenbach wrote: > > Hi, > > > > in commit 19ba0559 the FIGETBSZ (and FS_IOC_FIEMAP) ioctl was moved > > from file_ioctl() to do_vfs_ioctl(), so it also works for directories. > > The problem I'm seeing is that FIGETBSZ is defined as _IO(0x00,2) > > which is simply 2. so there is some potential for conflicts > > with character devices which do not use the _IO macros for numbering > > their ioctls. > > Just doing a web search for "FIGETBSZ ioctl conflict" shows > > that a few people already ran into this problem. > > > > Would you mind adding a check for S_ISDIR | S_ISREG, > > or maybe !S_ISCHR?
Yeah, I think the right thing to do here is a check for S_ISDIR | S_ISREG | S_ISLNK. - Ted
|  |