lkml.org 
[lkml]   [2010]   [Jun]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 07/12] vmscan: Remove unnecessary temporary vars in do_try_to_free_pages
    Date
    Remove temporary variable that is only used once and does not help
    clarify code.

    Signed-off-by: Mel Gorman <mel@csn.ul.ie>
    ---
    mm/vmscan.c | 8 +++-----
    1 files changed, 3 insertions(+), 5 deletions(-)

    diff --git a/mm/vmscan.c b/mm/vmscan.c
    index 6a42ebc..246e084 100644
    --- a/mm/vmscan.c
    +++ b/mm/vmscan.c
    @@ -1721,13 +1721,12 @@ static void shrink_zone(int priority, struct zone *zone,
    static bool shrink_zones(int priority, struct zonelist *zonelist,
    struct scan_control *sc)
    {
    - enum zone_type high_zoneidx = gfp_zone(sc->gfp_mask);
    struct zoneref *z;
    struct zone *zone;
    bool all_unreclaimable = true;

    - for_each_zone_zonelist_nodemask(zone, z, zonelist, high_zoneidx,
    - sc->nodemask) {
    + for_each_zone_zonelist_nodemask(zone, z, zonelist,
    + gfp_zone(sc->gfp_mask), sc->nodemask) {
    if (!populated_zone(zone))
    continue;
    /*
    @@ -1773,7 +1772,6 @@ static unsigned long do_try_to_free_pages(struct zonelist *zonelist,
    unsigned long lru_pages = 0;
    struct zoneref *z;
    struct zone *zone;
    - enum zone_type high_zoneidx = gfp_zone(sc->gfp_mask);
    unsigned long writeback_threshold;

    get_mems_allowed();
    @@ -1785,7 +1783,7 @@ static unsigned long do_try_to_free_pages(struct zonelist *zonelist,
    * mem_cgroup will not do shrink_slab.
    */
    if (scanning_global_lru(sc)) {
    - for_each_zone_zonelist(zone, z, zonelist, high_zoneidx) {
    + for_each_zone_zonelist(zone, z, zonelist, gfp_zone(sc->gfp_mask)) {

    if (!cpuset_zone_allowed_hardwall(zone, GFP_KERNEL))
    continue;
    --
    1.7.1


    \
     
     \ /
      Last update: 2010-06-14 13:21    [W:0.046 / U:32.744 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site