Messages in this thread | | | Date | Sun, 13 Jun 2010 12:01:21 +0200 | From | Ingo Molnar <> | Subject | Re: [PATCH 1/2] Remove preempt_enable/disable calls around sched_clock() |
| |
* Divyesh Shah <dpshah@google.com> wrote:
> On Sat, Jun 12, 2010 at 12:19 AM, Ingo Molnar <mingo@elte.hu> wrote: > > > > * Divyesh Shah <dpshah@google.com> wrote: > > > >> calls in the block layer. This was a temporary fix added. > > > > Not good, this commit reintroduces those ugly warnings, if someone happens to > > bisect straight into this commit. > > You're right. In the next version, I'll merge both patches into one so > this cannot happen.
Yeah - or if you really want to make a point of doing the two things in two separate patches you can first fix the API, _then_ remove the preemption enable/disable.
Thanks,
Ingo
| |