Messages in this thread |  | | | Subject | Re: [PATCHv5 09/16] btrfs: remove junk sb_mark_dirty call | | From | Artem Bityutskiy <> | | Date | Sat, 12 Jun 2010 10:36:47 +0300 |
| |
Chris,
could you please ack or nack this patch?
On Sun, 2010-06-06 at 17:50 +0300, Artem Bityutskiy wrote: > From: Artem Bityutskiy <Artem.Bityutskiy@nokia.com> > > BTRFS does not define '->write_super()' method, so it should not > mark its superblock as dirty. This looks like some left-over. > > Signed-off-by: Artem Bityutskiy <Artem.Bityutskiy@nokia.com> > Cc: Chris Mason <chris.mason@oracle.com> > --- > fs/btrfs/inode.c | 1 - > 1 files changed, 0 insertions(+), 1 deletions(-) > > diff --git a/fs/btrfs/inode.c b/fs/btrfs/inode.c > index caa4ed9..1419d90 100644 > --- a/fs/btrfs/inode.c > +++ b/fs/btrfs/inode.c > @@ -2938,7 +2938,6 @@ int btrfs_unlink_subvol(struct btrfs_trans_handle *trans, > dir->i_mtime = dir->i_ctime = CURRENT_TIME; > ret = btrfs_update_inode(trans, root, dir); > BUG_ON(ret); > - sb_mark_dirty(dir->i_sb); > > btrfs_free_path(path); > return 0;
-- Best Regards, Artem Bityutskiy (Артём Битюцкий)
-- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
|  |