lkml.org 
[lkml]   [2010]   [Jun]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH] staging:comedi: Fixed coding convention issues.
    From
    2010/6/12 Henri Häkkinen <henuxd@gmail.com>:
    > -                       printk
    > -                           (KERN_INFO "comedi: failed to increment module count, skipping\n");
    > +                       printk(KERN_INFO "comedi: failed to increment module "
    > +                              "count, skipping\n");

    Hi Henri,

    Regarding your breaking up of printk statements, although some of
    those lines do go over 80 characters, it is preferable to keep the
    strings together since then those are searchable within the code.

    I figure it is quite acceptable to break the string after "comedi: ",
    so maybe that will fix the line length issue, otherwise it is
    preferable to keep the checkpatch warning in this case.

    Mark
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2010-06-13 04:23    [W:0.019 / U:33.872 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site