lkml.org 
[lkml]   [2010]   [Jun]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v4] ocfs2: Let ocfs2_setattr use new truncate sequence.
On Fri, Jun 11, 2010 at 09:19:45AM +0200, Christoph Hellwig wrote:
> On Fri, Jun 11, 2010 at 03:16:13PM +0800, Tao Ma wrote:
> > oh, that would be much work for ocfs2 to do from my perspective. So I
> > would really want to leave it as-is and I have add it to my to-do list.
>
> Oh right, you start a new transaction there. Sorry, ignore my request
> and keep it as it is for now. I don't think doing truncatate in separate
> transactions actually is correct, though but that's no change with this
> patch.

Christoph,
You're missing the part where actual truncate (reduce i_size)
sets i_size in ocfs2_truncate_file(). So this later code doesn't get
triggered for the truncate case. It exists for the extend case, where
we extend the allocation in multiple clean transactions, then finally
set i_size in a final transaction.

Joel

--

"When choosing between two evils, I always like to try the one
I've never tried before."
- Mae West

Joel Becker
Principal Software Developer
Oracle
E-mail: joel.becker@oracle.com
Phone: (650) 506-8127


\
 
 \ /
  Last update: 2010-06-11 09:53    [W:0.042 / U:1.884 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site