Messages in this thread | | | Date | Fri, 11 Jun 2010 08:56:35 +0200 | From | Christoph Hellwig <> | Subject | Re: [PATCH v4] ocfs2: Let ocfs2_setattr use new truncate sequence. |
| |
This looks correct, but still has the second if ATTR_SIZE block that I commented on last time. I'd really prefer if the filesystems could move the truncate handling into a single conditional to simplify auditing for it and possibly splitting it out into a separate method later.
And btw, the S_ISREG check which you only have on the first ATTR_SIZE check is superflous, the VFS only does ATTR_SIZE calls on regular files.
| |