Messages in this thread |  | | | Date | Fri, 11 Jun 2010 12:27:51 -0400 | | From | Christoph Hellwig <> | | Subject | Re: [PATCH 5/6] vmscan: Write out ranges of pages contiguous to the inode where possible |
| |
On Thu, Jun 10, 2010 at 11:10:45PM -0700, Andrew Morton wrote: > I did this, umm ~8 years ago and ended up reverting it because it was > complex and didn't seem to buy us anything. Of course, that was before > we broke the VM and started writing out lots of LRU pages. That code > was better than your code - it grabbed the address_space and did > writearound around the target page.
> Or don't take a look - we shouldn't need to do any of this anyway.
Doing nearly 100% of the writepage from the flusher threads would also be preferable from the filesystem point of view - getting I/O from one thread helps to make it more local and work around all the stupid I/O controller logic that tries to make our life difficult.
Of course getting rid of ->writepage from the AOPs API one day would also be nice to simplify the filesystems code, but it's not that important.
|  |