lkml.org 
[lkml]   [2010]   [Jun]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [tip:sched/core] sched: Fix capacity calculations for SMT4
From
Date
On Thu, 2010-06-10 at 09:03 +1000, Michael Neuling wrote:
> Peter,
>
> It looks like when this was pushed to Ingo, some of the logic was
> changed. rt_freq_influence() became fix_small_capacity() but the return
> values for these two functions are opposite (return 1 => return 0 and
> visa versa]]).
>
> This was changed in the sibling test (return 1 => return 0), but the
> check for the change in cpu power due to freq and rt was not.
>
> So either the return values need to be changed at the end of
> fix_small_capacity() or the cpu_power test needs to be the other way
> around. Below changes the cpu_power test as it brings it more inline
> with the comment above it.
>
> Without this the asymmetric packing doesn't work.

D'oh fully my fault for cleaning up.

Thanks, I'll make sure it gets fixed.

> Subject: sched: fix the CPU power test for fix_small_capacity
>
> The CPU power test is the wrong way around in fix_small_capacity.
>
> This was due to a small changes made in the posted patch on lkml to what
> was was taken upstream.
>
> This patch fixes asymmetric packing for POWER7.
>
> Signed-off-by: Michael Neuling <mikey@neuling.org>
>
> Index: linux-2.6-ozlabs/kernel/sched_fair.c
> ===================================================================
> --- linux-2.6-ozlabs.orig/kernel/sched_fair.c
> +++ linux-2.6-ozlabs/kernel/sched_fair.c
> @@ -2354,7 +2354,7 @@ fix_small_capacity(struct sched_domain *
> /*
> * If ~90% of the cpu_power is still there, we're good.
> */
> - if (group->cpu_power * 32 < group->cpu_power_orig * 29)
> + if (group->cpu_power * 32 > group->cpu_power_orig * 29)
> return 1;
>
> return 0;
>



\
 
 \ /
  Last update: 2010-06-10 08:51    [W:0.075 / U:1.008 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site