lkml.org 
[lkml]   [2010]   [Jun]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] Marvell OpenRD-Ultimate machine support
Hi,

* Dmytro Milinevskyy <milinevskyy@gmail.com> [2010-06-10 05:24:56+0300]:
>
> [snipped]
>
> @@ -84,8 +90,7 @@ static void __init openrd_init(void)
>
> static int __init openrd_pci_init(void)
> {
> - if (machine_is_openrd_base() || machine_is_openrd_client())
> - kirkwood_pcie_init();
> + kirkwood_pcie_init();
>
> return 0;
> }
>
You just 'broke' kirkwood, welcome to the club. We all have done this:

http://marc.info/?l=linux-arm-kernel&m=125624586625065&w=2
http://marc.info/?l=linux-arm-kernel&m=125804222219159&w=2

Put that 'if()' clause back in, the 'subsys_initcall(openrd_pci_init)'
causes that code to run on *all* compiled in boards (think of the case
where you have SheevaPlug's also enabled).

Cheers

--
Alexander Clouter
.sigmonster says: Poverty begins at home.


\
 
 \ /
  Last update: 2010-06-10 07:53    [W:0.551 / U:0.236 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site