Messages in this thread | | | Date | Thu, 10 Jun 2010 09:57:32 -0400 | From | Jason Baron <> | Subject | Re: [PATCH 10/13] jump label v9: convert jump label to use a key |
| |
On Thu, Jun 10, 2010 at 02:43:46PM +0200, Peter Zijlstra wrote: > On Wed, 2010-06-09 at 17:39 -0400, Jason Baron wrote: > > -static inline int enable_jump_label(const char *name) > > -{ > > - return 0; > > -} > > - > > -static inline int disable_jump_label(const char *name) > > -{ > > - return 0; > > -} > > +#define enable_jump_label(key) > > +#define disable_jump_label(key) > > I would expect enable_jump_label() to look something like: > > #define enable_jump_label(cond_var) \ > do { \ > *(cond_var) = 1; \ > } while (0) > > That way the HAVE_JUMP_LABEL and !HAVE_JUMP_LABEL code has similar > effects.
right. I was going to clean that up in a followup. But you are right - I think it makes the code much clearer. will fix.
thanks,
-Jason
| |