lkml.org 
[lkml]   [2010]   [Jun]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH] [8/23] KGDB: Remove set but unused newPC
    Date

    I'm not fully sure this is the correct fix, maybe this
    was a bug and newPC should really have a side effect.
    Jason?

    Found by gcc 4.6's new warnings

    Cc: jason.wessel@windriver.com

    Signed-off-by: Andi Kleen <ak@linux.intel.com>

    ---
    arch/x86/kernel/kgdb.c | 3 ---
    1 file changed, 3 deletions(-)

    Index: linux-2.6.35-rc2-gcc/arch/x86/kernel/kgdb.c
    ===================================================================
    --- linux-2.6.35-rc2-gcc.orig/arch/x86/kernel/kgdb.c
    +++ linux-2.6.35-rc2-gcc/arch/x86/kernel/kgdb.c
    @@ -458,7 +458,6 @@ int kgdb_arch_handle_exception(int e_vec
    {
    unsigned long addr;
    char *ptr;
    - int newPC;

    switch (remcomInBuffer[0]) {
    case 'c':
    @@ -469,8 +468,6 @@ int kgdb_arch_handle_exception(int e_vec
    linux_regs->ip = addr;
    case 'D':
    case 'k':
    - newPC = linux_regs->ip;
    -
    /* clear the trace bit */
    linux_regs->flags &= ~X86_EFLAGS_TF;
    atomic_set(&kgdb_cpu_doing_single_step, -1);

    \
     
     \ /
      Last update: 2010-06-10 13:17    [W:0.028 / U:2.112 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site