lkml.org 
[lkml]   [2010]   [Jun]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [linux-pm] [PATCH 0/8] Suspend block api (version 8)
    From
    On Tue, Jun 1, 2010 at 7:05 AM, mark gross <640e9920@gmail.com> wrote:
    > On Tue, Jun 01, 2010 at 09:07:37AM +0200, Florian Mickler wrote:
    ...
    >> +static void update_target_val(int pm_qos_class, s32 val)
    >> +{
    >> +     s32 extreme_value;
    >> +     s32 new_value;
    >> +     extreme_value = atomic_read(&pm_qos_array[pm_qos_class]->target_value);
    >> +     new_value = pm_qos_array[pm_qos_class]->comparitor(val,extreme_value);
    >> +     if (extreme_value != new_value)
    >> +             atomic_set(&pm_qos_array[pm_qos_class]->target_value,new_value);
    >> +}
    >> +
    >
    > Only works 1/2 the time, but I like the idea!
    > It fails to get the righ answer when constraints are reduced.  But, this
    > idea is a good improvement i'll roll into the next pm_qos update!
    >

    I think it would be a better idea to track your constraints with a
    sorted data structure. That way you can to better than O(n) for both
    directions. If you have a lot of constraints with the same value, it
    may even be worthwhile to have a two stage structure where for
    instance you use a rbtree for the unique values and list for identical
    constraints.

    --
    Arve Hjønnevåg
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2010-06-02 05:53    [W:0.023 / U:0.360 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site