lkml.org 
[lkml]   [2010]   [Jun]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/5] oom: select_bad_process: check PF_KTHREAD instead of !mm to skip kthreads
On Mon, 31 May 2010, KOSAKI Motohiro wrote:

> From: Oleg Nesterov <oleg@redhat.com>
> Subject: oom: select_bad_process: check PF_KTHREAD instead of !mm to skip kthreads
>
> select_bad_process() thinks a kernel thread can't have ->mm != NULL, this
> is not true due to use_mm().
>
> Change the code to check PF_KTHREAD.
>
> Signed-off-by: Oleg Nesterov <oleg@redhat.com>
> Acked-by: David Rientjes <rientjes@google.com>
> Signed-off-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>

This is already pushed in my oom killer rewrite as patch 14/18 "check
PF_KTHREAD instead of !mm to skip kthreads".

This does not need to be merged immediately since it's not vital: use_mm()
is only temporary state and these kthreads will once again be excluded
when they call unuse_mm(). The worst case scenario here is that the oom
killer will erroneously select one of these kthreads which cannot die and
will need to reselect another task on its next call.


\
 
 \ /
  Last update: 2010-06-01 22:39    [W:0.294 / U:0.068 seconds]
©2003-2014 Jasper Spaans. Advertise on this site