lkml.org 
[lkml]   [2010]   [Jun]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 2/5] oom: remove warning for in mm-less task __oom_kill_process()
    Date
    If the race of mm detach in task exiting vs oom is happen,
    find_lock_task_mm() can be return NULL.

    So, the warning is pointless. remove it.


    Signed-off-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
    ---
    mm/oom_kill.c | 6 +-----
    1 files changed, 1 insertions(+), 5 deletions(-)

    diff --git a/mm/oom_kill.c b/mm/oom_kill.c
    index bac4515..70e1a85 100644
    --- a/mm/oom_kill.c
    +++ b/mm/oom_kill.c
    @@ -402,12 +402,8 @@ static int __oom_kill_process(struct task_struct *p, struct mem_cgroup *mem,
    return 1;

    p = find_lock_task_mm(p);
    - if (!p) {
    - WARN_ON(1);
    - printk(KERN_WARNING "tried to kill an mm-less task %d (%s)!\n",
    - task_pid_nr(p), p->comm);
    + if (!p)
    return 1;
    - }

    if (verbose)
    printk(KERN_ERR "Killed process %d (%s) "
    --
    1.6.5.2




    \
     
     \ /
      Last update: 2010-06-01 07:51    [W:0.023 / U:0.252 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site