lkml.org 
[lkml]   [2010]   [Jun]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/2] Make the module 'usage' lists be two-way


On Mon, 31 May 2010, Linus Torvalds wrote:
>
> Oh. And back then, it was inside a "modlist_lock". And that lock is long
> gone, but the GFP_ATOMIC remains.

Actually, keep it that way. Because I think that with your locking
cleanup, we could actually turn the module_mutex back into a spinlock.

And the thing is, we don't necessarily want it to be a spinlock per se,
but at the same time, I think that would be a good sanity test. If we can
turn it into a spinlock without triggering the "might_sleep()" debugging
code, that means that we are only holding it over real critical regions.

So while I don't think it needs to be a spinlock, it would be a nice added
sanity check if it were one. We have all this helper debugging code to
verify that spinlocked regions don't do "bad" things.

Linus


\
 
 \ /
  Last update: 2010-06-01 06:13    [W:0.097 / U:0.124 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site