Messages in this thread | | | Date | Mon, 31 May 2010 21:05:55 -0700 (PDT) | From | Linus Torvalds <> | Subject | Re: [PATCH 1/2] Make the module 'usage' lists be two-way |
| |
On Mon, 31 May 2010, Linus Torvalds wrote: > > Oh. And back then, it was inside a "modlist_lock". And that lock is long > gone, but the GFP_ATOMIC remains.
Actually, keep it that way. Because I think that with your locking cleanup, we could actually turn the module_mutex back into a spinlock.
And the thing is, we don't necessarily want it to be a spinlock per se, but at the same time, I think that would be a good sanity test. If we can turn it into a spinlock without triggering the "might_sleep()" debugging code, that means that we are only holding it over real critical regions.
So while I don't think it needs to be a spinlock, it would be a nice added sanity check if it were one. We have all this helper debugging code to verify that spinlocked regions don't do "bad" things.
Linus
| |