lkml.org 
[lkml]   [2010]   [Jun]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[PATCH 1/2] mac8390: propagate error code from request_irq

    Use the request_irq() error code as the return value for mac8390_open().
    EAGAIN doesn't make sense for Nubus slot IRQs. Only this driver can claim
    this IRQ (until the NIC is removed, which means everything is powered
    down).

    Signed-off-by: Finn Thain <fthain@telegraphics.com.au>

    Index: linux-2.6.34/drivers/net/mac8390.c
    ===================================================================
    --- linux-2.6.34.orig/drivers/net/mac8390.c 2010-06-01 20:20:29.000000000 +1000
    +++ linux-2.6.34/drivers/net/mac8390.c 2010-06-01 20:22:23.000000000 +1000
    @@ -643,12 +643,13 @@ static int __init mac8390_initdev(struct

    static int mac8390_open(struct net_device *dev)
    {
    + int err;
    +
    __ei_open(dev);
    - if (request_irq(dev->irq, __ei_interrupt, 0, "8390 Ethernet", dev)) {
    - pr_info("%s: unable to get IRQ %d.\n", dev->name, dev->irq);
    - return -EAGAIN;
    - }
    - return 0;
    + err = request_irq(dev->irq, __ei_interrupt, 0, "8390 Ethernet", dev);
    + if (err)
    + pr_info("%s: unable to get IRQ %d\n", dev->name, dev->irq);
    + return err;
    }

    static int mac8390_close(struct net_device *dev)

    \
     
     \ /
      Last update: 2010-06-01 14:21    [W:0.019 / U:0.128 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site