lkml.org 
[lkml]   [2010]   [May]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/2] mm,migration: Fix race between shift_arg_pages and rmap_walk by guaranteeing rmap_walk finds PTEs created within the temporary stack


On Sun, 9 May 2010, Linus Torvalds wrote:
>
> IOW, a patch like this (this is a pseudo-patch, totally untested, won't
> compile, yadda yadda - you need to actually make the people who call
> "move_page_tables()" call that prepare function first etc etc)

Btw, that pseudo-patch is also likely the least efficient way to do this,
since it re-walks the page directories for each pmd it creates.

Also - the thing is, we can easily choose to do this _just_ for the case
of shifting argument pages, which really is a special case (the generic
case of "mremap()" is a lot more complicated, and doesn't have the issue
with rmap because it's doing all the "new vma" setup etc).

Linus


\
 
 \ /
  Last update: 2010-05-09 22:11    [from the cache]
©2003-2014 Jasper Spaans. Advertise on this site