Messages in this thread | | | Date | Fri, 7 May 2010 17:09:51 -0700 | Subject | Re: [PATCH] DMA ENGINE: Do not reset 'private' of channel | From | Dan Williams <> |
| |
On Tue, May 4, 2010 at 2:22 AM, Jassi Brar <jassi.brar@samsung.com> wrote: > The member 'private' of 'struct dma_chan' is meant for passing > data between client and the controller driver. > > The DMA client driver may point it to platform specific stuff after > acquiring the channel. So, it is the responsiblity of the same code > to reset it, if it must. > > The DMA engine doesn't set it and hence, shouldn't reset it either. > > Signed-off-by: Jassi Brar <jassi.brar@samsung.com> > > This reseting of private by DMA Engine comes in the way of implementing > default channel settings during DMAC probe. That capability is useful > for not having the clients to always provide platform specific data, > like Rx/Tx FIFO addresses, which usually doesn't change across channel > requests. >
Ok I like this explanation better than the changelog you have above because it clarifies that the driver is setting a default that the client can override at registration time, but when this is happening dmaengine should get out of the way.
Applied.
Thanks, Dan
| |