lkml.org 
[lkml]   [2010]   [May]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] get_maintainer.pl: ignore non-maintainer tags
Florian Mickler wrote:
> On Thu, May 06, 2010 at 11:39:26PM -0700, Joe Perches wrote:
>> On Fri, 2010-05-07 at 08:34 +0200, florian@mickler.org wrote:
>>> Using --git to determine who to send a patch to, it is not
>>> reasonable to include people that only reported an issue or tested a
>>> patch.
>> I think this is a questionable assumption.
>>
>> People that test or otherwise sign a patch are also good
>> candidates to review new patches.
>>
>> cheers, Joe
>
> Our views differ then.
>
> It is unreasonable to assume, that someone who is listed via
> Tested-By: in a random patch is able to review another patch to the same
> file. More likely will he be annoyed, because he see's a patch, dig's
> in and then thinks: "wtf? why were i cc'ed on this. I don't know this
> code. I don't have time for this!"
>
> Thats just broken.

Indeed. Three points:

- Reported-by: and Tested-by: signed commits were most likely about
something radically different from what the new patch submission is
about.

- get_maintainer.pl is supposed to list maintainer addresses.
Reporters and testers are not maintainers.

- If a get_maintainer.pl user expects to get not only maintainer
addresses but also addresses of potential reviewers, then he shall
use the mailinglist addresses for that.
People who /want/ to review patches subscribe to that mailinglist
or register themselves in MAINTAINERS.

Pushing patches to people of whom it is unknown whether they want or can
review the patches may actually be rude. If it can be avoided that
get_maintainer.pl lists addresses of people who are likely of that
category, then please teach it to.
--
Stefan Richter
-=====-==-=- -=-= --===
http://arcgraph.de/sr/

\
 
 \ /
  Last update: 2010-05-07 21:51    [from the cache]
©2003-2014 Jasper Spaans. Advertise on this site