lkml.org 
[lkml]   [2010]   [May]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] Add clocksource_register_hz/khz interface
From
Date
On Fri, 2010-05-07 at 17:44 +0200, Thomas Gleixner wrote:
> On Wed, 5 May 2010, John Stultz wrote:
>
> > Hey Thomas,
> > I updated the patch docs and made the calls EXPORT_SYMBOL_GPL.
> > However the need for both khz and hz is due to high freq clocksources
> > like the TSC who's cycles/sec are close to the upper bound of a u32.
>
> Come on. It's not that hard :)

Oh... So your fine with having two interfaces, but just want the code
redundancy removed between the two interfaces?

Ok, I misunderstood. That's no problem.

thanks
-john


> int clocksource_register_freq(struct clocksource *cs, u32 scale, u32 freq)
> {
> clocks_calc_mult_shift(&cs->mult, &cs->shift, freq,
> NSEC_PER_SEC / scale, MAX_UPDATE_LENGTH * scale);
>
> ....
> }
>
> static inline int clocksource_register_hz(struct clocksource *cs, u32 freq)
> {
> clocksource_regiser_freq(cs, 1, freq);
> }
>
> static inline int clocksource_register_khz(struct clocksource *cs, u32 freq)
> {
> clocksource_regiser_freq(cs, 1000, freq);
> }
>
> Thanks,
>
> tglx




\
 
 \ /
  Last update: 2010-05-07 20:53    [W:2.027 / U:0.024 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site