Messages in this thread | | | Subject | Re: [PATCH 2/9 - v2][RFC] tracing: Let tracepoints have data?passed to tracepoint callbacks | From | Steven Rostedt <> | Date | Fri, 07 May 2010 11:45:25 -0400 |
| |
On Fri, 2010-05-07 at 11:30 -0400, Mathieu Desnoyers wrote: > * Steven Rostedt (rostedt@goodmis.org) wrote:
> > I'm fine with forcing all callbacks to include a data parameter if you > > are. This would also make the changes simpler. > > Yes, I am all for it.
Great! I'm making the changes now.
> > As for the extra type checking, it is basically just trying to force you to > generate matching caller-callee prototypes in your CPP macros. The goal is > really to check that the data parameter type match in both the caller and > callee. I see that as a mean to make sure nobody is going to try to take > shortcuts by playing with the callback types in the "undefined behavior" zone of > the C standard in future TRACE_EVENT() modifications.
OK, I'll wait for your patch. As my favorite saying goes...
"When people ask me what language my mother tongue is, I simply reply 'C'."
-- Steve
| |