lkml.org 
[lkml]   [2010]   [May]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 3/9 - v2][RFC] tracing: Remove per event trace registering
From
Date
On Fri, 2010-05-07 at 16:20 +0800, Li Zefan wrote:
> > @@ -935,11 +947,11 @@ event_create_dir(struct ftrace_event_call *call, struct dentry *d_events,
> > return -1;
> > }
> >
> > - if (call->regfunc)
> > + if (call->class->probe || call->class->reg)
> > trace_create_file("enable", 0644, call->dir, call,
> > enable);
> >
> > - if (call->id && call->perf_event_enable)
> > + if (call->id && (call->class->perf_probe || call->class->reg))
> > trace_create_file("id", 0444, call->dir, call,
> > id);
> >
>
> Accessing of ->perf_probe needs to be guarded with CONFIG_PERF_EVENTS,
> otherwise it won't pass compile.
>
> The original code is fine, because ->perf_event_enable is always there
> regardless of CONFIG_PERF_EVENTS.

Good catch! I wanted to test the !CONFIG_PERF_EVENTS but that needs to
be done on a non x86 box. I'll need to do that before posting my non-RFC
patch set.

-- Steve




\
 
 \ /
  Last update: 2010-05-07 15:01    [W:0.163 / U:0.040 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site