lkml.org 
[lkml]   [2010]   [May]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 3/7] scsi: megaraid_sas - Online COntroller Reset (OCR) PART-III
    On 05/06/2010 05:52 PM, Yang, Bo wrote:
    > This is third part of the Online Controller Reset. In ISR routine, if driver receive the FW state change interrupt
    > And the online controller reset support enabled in FW, driver will read the controller register. Driver will issue
    > Controller reset if the FW register state failure. Also driver will back up the pending cmds for the re-fire after
    > the reset finished.
    >
    > Also Driver added the CTIO support to this patch.
    >
    > Signed-off-by Bo Yang<bo.yang@lsi.com>
    >
    > +static void
    > +process_fw_state_change_wq(struct work_struct *work)
    > +{
    > + struct megasas_instance *instance =
    > + container_of(work, struct megasas_instance, work_init);
    > + u32 wait;
    > + unsigned long flags;
    > +
    > + if (instance->adprecovery != MEGASAS_ADPRESET_SM_INFAULT) {
    > + printk(KERN_NOTICE "megaraid_sas: error, recovery st %x \n",
    > + instance->adprecovery);
    > + return ;
    > + }
    > +
    > + if (instance->adprecovery == MEGASAS_ADPRESET_SM_INFAULT) {
    > + printk(KERN_NOTICE "megaraid_sas: FW detected to be in fault"
    > + "state, restarting it...\n");
    > +
    > + instance->instancet->disable_intr(instance->reg_set);
    > + atomic_set(&instance->fw_outstanding, 0);
    > +
    > + atomic_set(&instance->fw_reset_no_pci_access, 1);
    > + instance->instancet->adp_reset(instance, instance->reg_set);
    > + atomic_set(&instance->fw_reset_no_pci_access, 0 );
    > +
    > + printk(KERN_NOTICE "megaraid_sas: FW restarted successfully,"
    > + "initiating next stage...\n");
    > +
    > + printk(KERN_NOTICE "megaraid_sas: HBA recovery state machine,"
    > + "state 2 starting...\n");
    > +
    > + /*waitting for about 20 second before start the second init*/
    > + for (wait = 0; wait < 30; wait++) {
    > + msleep(1000);
    > + }
    >
    Hi Bo,
    I'm only curios - couldn't be the above loop replaced by ssleep(30);
    and have the u32 wait; removed?
    + ssleep(30); /* wait for about 30 second before second init */

    I guess you wanted to have a space after the comma in the printk, if yes I think
    you should do this -> printk(KERN_NOTICE "megaraid_sas: HBA recovery state machine, "

    It might be a problem with my mail reader, but it seems to me that you are using
    spaces instead of tabs almost everywhere.

    Tomas




    \
     
     \ /
      Last update: 2010-05-07 14:57    [W:0.280 / U:64.284 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site