Messages in this thread | | | Date | Fri, 07 May 2010 19:37:30 +1000 | From | Nigel Cunningham <> | Subject | Re: [PATCH] Check kmalloc return value before use the buffer |
| |
Hi.
No commit comment?
On 07/05/10 17:17, Steven Liu wrote: > Signed-off-by: LiuQi<lingjiujianke@gmail.com> > --- > arch/arm/mach-u300/dummyspichip.c | 5 +++++ > 1 files changed, 5 insertions(+), 0 deletions(-) > > diff --git a/arch/arm/mach-u300/dummyspichip.c > b/arch/arm/mach-u300/dummyspichip.c > index 5f55012..df19f9b 100644 > --- a/arch/arm/mach-u300/dummyspichip.c > +++ b/arch/arm/mach-u300/dummyspichip.c > @@ -64,6 +64,11 @@ static ssize_t dummy_looptest(struct device *dev, > goto out; > } > bigrxbuf_virtual = kmalloc(DMA_TEST_SIZE, GFP_KERNEL); > + if (bigrxbuf_virtual == NULL) { > + status = -ENOMEM; > + kfree(bigtxbuf_virtual);
Why kfree something you know is NULL?
Regards,
Nigel
| |