lkml.org 
[lkml]   [2010]   [May]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[RFC][PATCH v5 11/19] Use callback to deal with skb_release_data() specially.
    Date
    From: Xin Xiaohui <xiaohui.xin@intel.com>

    If buffer is external, then use the callback to destruct
    buffers.

    Signed-off-by: Xin Xiaohui <xiaohui.xin@intel.com>
    Signed-off-by: Zhao Yu <yzhao81new@gmail.com>
    Reviewed-by: Jeff Dike <jdike@linux.intel.com>
    ---
    net/core/skbuff.c | 11 +++++++++++
    1 files changed, 11 insertions(+), 0 deletions(-)

    diff --git a/net/core/skbuff.c b/net/core/skbuff.c
    index 169f22c..5d93b2d 100644
    --- a/net/core/skbuff.c
    +++ b/net/core/skbuff.c
    @@ -385,6 +385,11 @@ static void skb_clone_fraglist(struct sk_buff *skb)

    static void skb_release_data(struct sk_buff *skb)
    {
    + /* check if the skb has external buffers, we have use destructor_arg
    + * here to indicate
    + */
    + struct skb_external_page *ext_page = skb_shinfo(skb)->destructor_arg;
    +
    if (!skb->cloned ||
    !atomic_sub_return(skb->nohdr ? (1 << SKB_DATAREF_SHIFT) + 1 : 1,
    &skb_shinfo(skb)->dataref)) {
    @@ -397,6 +402,12 @@ static void skb_release_data(struct sk_buff *skb)
    if (skb_has_frags(skb))
    skb_drop_fraglist(skb);

    + /* if the skb has external buffers, use destructor here,
    + * since after that skb->head will be kfree, in case skb->head
    + * from external buffer cannot use kfree to destroy.
    + */
    + if (dev_is_mpassthru(skb->dev) && ext_page && ext_page->dtor)
    + ext_page->dtor(ext_page);
    kfree(skb->head);
    }
    }
    --
    1.5.4.4


    \
     
     \ /
      Last update: 2010-05-07 11:39    [W:0.031 / U:91.260 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site