Messages in this thread | | | From | Mike Frysinger <> | Date | Thu, 6 May 2010 14:26:00 -0400 | Subject | Re: [PATCH] ad7877: fix spi word size to 16 bit |
| |
On Thu, May 6, 2010 at 06:37, Oskar Schirmer wrote: > --- a/drivers/input/touchscreen/ad7877.c > +++ b/drivers/input/touchscreen/ad7877.c > @@ -669,6 +669,8 @@ static int __devinit ad7877_probe(struct spi_device *spi) > dev_dbg(&spi->dev, "SPI CLK %d Hz?\n",spi->max_speed_hz); > return -EINVAL; > } > + spi->bits_per_word = 16; > + spi_setup(spi);
i think it'd be a better idea to do something like: if (spi->bits_per_word != 16) { if (spi->bits_per_word) { dev_err(&spi->dev, "Invalid SPI settings; bits_per_word must be 16\n"); return -EINVAL; } spi->bits_per_word = 16; spi_setup(spi); } -mike -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |