Messages in this thread | | | Date | Thu, 6 May 2010 15:18:13 +0900 | From | KAMEZAWA Hiroyuki <> | Subject | Re: [PATCH 1/2] mm: remove unnecessary use of atomic |
| |
On Wed, 5 May 2010 14:21:48 +0300 Phil Carmody <ext-phil.2.carmody@nokia.com> wrote:
> From: Phil Carmody <ext-phil.2.carmody@nokia.com> > > The bottom 4 hunks are atomically changing memory to which there > are no aliases as it's freshly allocated, so there's no need to > use atomic operations. > > The other hunks are just atomic_read and atomic_set, and do not > involve any read-modify-write. The use of atomic_{read,set} > doesn't prevent a read/write or write/write race, so if a race > were possible (I'm not saying one is), then it would still be > there even with atomic_set. > > See: > http://digitalvampire.org/blog/index.php/2007/05/13/atomic-cargo-cults/ > > Signed-off-by: Phil Carmody <ext-phil.2.carmody@nokia.com> > Acked-by: Kirill A. Shutemov <kirill@shutemov.name>
Acked-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
| |