lkml.org 
[lkml]   [2010]   [May]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] Staging: comedi: fix coding style issues in comedi_fops.c This patch fixes coding style issues reported by scripts/checkpatch.pl Signed-off-by: Zachary Richey <>
On Wed, May 05, 2010 at 10:39:47PM -0400, Zachary Richey wrote:
> ---
> drivers/staging/comedi/comedi_fops.c | 56 +++++++++++++++++-----------------
> 1 files changed, 28 insertions(+), 28 deletions(-)
>
> diff --git a/drivers/staging/comedi/comedi_fops.c b/drivers/staging/comedi/comedi_fops.c
> index aca9674..999cbb6 100644
> --- a/drivers/staging/comedi/comedi_fops.c
> +++ b/drivers/staging/comedi/comedi_fops.c
> @@ -598,20 +598,20 @@ copyback:
> static int parse_insn(struct comedi_device *dev, struct comedi_insn *insn,
> unsigned int *data, void *file);
> /*
> - * COMEDI_INSNLIST
> - * synchronous instructions
> - *
> - * arg:
> - * pointer to sync cmd structure
> - *
> - * reads:
> - * sync cmd struct at arg
> - * instruction list
> - * data (for writes)
> - *
> - * writes:
> - * data (for reads)
> - */
> +* COMEDI_INSNLIST
> +* synchronous instructions
> +*
> +* arg:
> +* pointer to sync cmd structure
> +*
> +* reads:
> +* sync cmd struct at arg
> +* instruction list
> +* data (for writes)
> +*
> +* writes:
> +* data (for reads)
> +*/
> /* arbitrary limits */
> #define MAX_SAMPLES 256
> static int do_insnlist_ioctl(struct comedi_device *dev, void *arg, void *file)
> @@ -736,7 +736,7 @@ static int check_insn_config_length(struct comedi_insn *insn,


What warning is this patch resolving? The original looks correct, a
leading space is fine for something like a comment block like this.

confused,

greg k-h


\
 
 \ /
  Last update: 2010-05-06 08:25    [W:0.028 / U:0.824 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site