lkml.org 
[lkml]   [2010]   [May]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH 03/12] perf: add perf_event_task_migrate()
    From
    Date
    On Wed, 2010-05-05 at 11:37 +0200, Tejun Heo wrote:
    > On 05/05/2010 11:11 AM, Peter Zijlstra wrote:
    > > On Wed, 2010-05-05 at 07:08 +0200, Frederic Weisbecker wrote:
    > >>
    > >> In fact why not moving both tracing calls under this check.
    > >> This is going to fix the migrate trace event that gets called
    > >> even on "spurious" migrations, and you avoid the duplicate check
    > >> in the perf callback.
    > >
    > > I kept the tracepoint out of that because I wanted to see how often it
    > > attempts silly migrations :-)
    >
    > Do you still need to keep it or is it okay to move it under the
    > silliness check?

    I guess you can move it, I often end up adding tons of trace_printk()
    anyway when hunting funnies, might as well add one here when its
    relevant.



    \
     
     \ /
      Last update: 2010-05-05 11:53    [W:0.022 / U:0.044 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site