Messages in this thread | | | Subject | Re: [PATCH 03/12] perf: add perf_event_task_migrate() | From | Peter Zijlstra <> | Date | Wed, 05 May 2010 11:50:25 +0200 |
| |
On Wed, 2010-05-05 at 11:37 +0200, Tejun Heo wrote: > On 05/05/2010 11:11 AM, Peter Zijlstra wrote: > > On Wed, 2010-05-05 at 07:08 +0200, Frederic Weisbecker wrote: > >> > >> In fact why not moving both tracing calls under this check. > >> This is going to fix the migrate trace event that gets called > >> even on "spurious" migrations, and you avoid the duplicate check > >> in the perf callback. > > > > I kept the tracepoint out of that because I wanted to see how often it > > attempts silly migrations :-) > > Do you still need to keep it or is it okay to move it under the > silliness check?
I guess you can move it, I often end up adding tons of trace_printk() anyway when hunting funnies, might as well add one here when its relevant.
| |