Messages in this thread | | | From | Eric Miao <> | Date | Wed, 5 May 2010 17:47:14 +0800 | Subject | Re: [PATCH] colibri.h: Fix building for colibri 270... |
| |
On Wed, May 5, 2010 at 5:44 PM, Daniel Mack <daniel@caiaq.de> wrote: > On Wed, May 05, 2010 at 05:28:45PM +0800, Eric Miao wrote: >> On Wed, May 5, 2010 at 4:00 PM, Daniel Mack <daniel@caiaq.de> wrote: >> > On Wed, May 05, 2010 at 03:45:34PM +0800, Eric Miao wrote: >> >> On Fri, Apr 16, 2010 at 7:29 PM, Daniel Mack <daniel@caiaq.de> wrote: >> >> > On Fri, Apr 16, 2010 at 01:28:20PM +0200, Daniel Mack wrote: >> >> >> On Fri, Apr 16, 2010 at 01:25:49PM +0200, Jakob Viketoft wrote: >> >> >> > Adding a "#include <mach/mfp.h>" seem to cure this problem. If you >> >> >> > agree I can supply a new patch with the correct solution this time. >> >> >> >> >> >> Ok. Add it to colibri.h, and while at it, you can kick the ax88796.h >> >> >> inclusion. That's a leftover and isn't needed. >> >> > >> >> > And Cc: stable@kernel.org for the backmerge to 2.6.33. >> >> > >> >> >> >> Jakob, any update on this? >> > >> > Jakob provided an updated patch for this: >> > >> > http://lkml.org/lkml/2010/4/16/100 >> > >> >> Looks it didn't make into -stable. > > Greg, stable@kernel.org was in Cc: for the patch in the URL above. > Any chance to get this in? > >> And I'm not able to find >> drivers/pcmcia/pxa2xx_colibri.c as well. > > Erm - how is that related to the patch in question? >
The error seems to be (as in previous mail):
CC drivers/pcmcia/pxa2xx_colibri.o In file included from drivers/pcmcia/pxa2xx_colibri.c:25: arch/arm/mach-pxa/include/mach/colibri.h:13: error: expected ')' before '*' token make[2]: *** [drivers/pcmcia/pxa2xx_colibri.o] Error 1 make[1]: *** [drivers/pcmcia] Error 2 make: *** [drivers] Error 2
And actually, inclusion of <mach/mfp.h> is better to be placed where it's used, i.e. drivers/pcmcia/pxa2xx_colibri.c.
> Daniel > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |