lkml.org 
[lkml]   [2010]   [May]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 0/3] ramzswap: Eliminate stale data in compressed memory


On Wed, 5 May 2010, Nitin Gupta wrote:
>
> I think such 'swap_operations' structure will be have to be part of
> block_device_operations, so we may access it from swap_entry_free()
> where a swap slot is freed. This will also get rid of all this notifier
> stuff.

Yes, I think adding it to block_device_operations would be fine. That
sounds like a sane layering, and would make it easy for a block device
driver to say "I want to know about swap events".

In fact, for regular block devices, a swap block free might well translate
into a TRIM command some day (where "some day" means when the SSD's
actually get their stuff together and there is real upside and not just
"most cases will be very slow and the upside is debatable").

> The patch you nacked did something similar: it add 'swap_slot_free_callback'
> directly to block_device_operations. Without such change, I could not think
> of any way to do away with notifiers.

Umm. No. IIRC, the patch I NAK'ed aded it to the 'swap_info_struct', which
I said was the wrong level. The block device driver level would seem to be
the _right_ level, since that's what ramzswap is. No?

Also, the patch I NAK'ed also used those nasty notifier chains, making it
even uglier.

Linus


\
 
 \ /
  Last update: 2010-05-05 18:27    [W:0.032 / U:8.192 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site