lkml.org 
[lkml]   [2010]   [May]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
DateWed, 5 May 2010 13:51:56 +0100
FromMel Gorman <>
SubjectRe: [PATCH] fix count_vm_event preempt in memory compaction direct reclaim
On Wed, May 05, 2010 at 02:19:08PM +0200, Andrea Arcangeli wrote:
> On Tue, Apr 20, 2010 at 10:01:14PM +0100, Mel Gorman wrote:
> > + if (page) {
> > + __count_vm_event(COMPACTSUCCESS);
> > + return page;
>
> ==
> From: Andrea Arcangeli <aarcange@redhat.com>
>
> Preempt is enabled so it must use count_vm_event.
>
> Signed-off-by: Andrea Arcangeli <aarcange@redhat.com>

Reviewed-by: Mel Gorman <mel@csn.ul.ie>

Andrew, this is a fix to the patch
mmcompaction-direct-compact-when-a-high-order-allocation-fails.patch

Thanks Andrea, well spotted.

> ---
>
> diff --git a/mm/page_alloc.c b/mm/page_alloc.c
> --- a/mm/page_alloc.c
> +++ b/mm/page_alloc.c
> @@ -1768,7 +1768,7 @@ __alloc_pages_direct_compact(gfp_t gfp_m
> alloc_flags, preferred_zone,
> migratetype);
> if (page) {
> - __count_vm_event(COMPACTSUCCESS);
> + count_vm_event(COMPACTSUCCESS);
> return page;
> }
>
>

--
Mel Gorman
Part-time Phd Student Linux Technology Center
University of Limerick IBM Dublin Software Lab


\
 
 \ /
  Last update: 2010-05-05 14:55    [from the cache]
©2003-2010