Messages in this thread | | | Date | Tue, 4 May 2010 16:24:57 -0700 | From | Andrew Morton <> | Subject | Re: [PATCH -mm 4/5] RapidIO: Add switch domain routines |
| |
On Mon, 3 May 2010 11:45:57 -0400 Alexandre Bounine <alexandre.bounine@idt.com> wrote:
> +static int > +idtcps_set_domain(struct rio_mport *mport, u16 destid, u8 hopcount, > + u8 sw_domain) > +{ > + /* > + * Switch domain configuration operates only at global level > + */ > + rio_mport_write_config_32(mport, destid, hopcount, > + IDTCPS_RIO_DOMAIN, (u32)sw_domain); > + return 0; > +} > + > +static int > +idtcps_get_domain(struct rio_mport *mport, u16 destid, u8 hopcount, > + u8 *sw_domain) > +{ > + u32 regval; > + > + /* > + * Switch domain configuration operates only at global level > + */ > + rio_mport_read_config_32(mport, destid, hopcount, > + IDTCPS_RIO_DOMAIN, ®val); > + > + *sw_domain = (u8)(regval & 0xff); > + > + return 0; > +}
This ignores the return values from rio_mport_write_config_*().
AFACIT these things always return hard-wired 0 anyway. Perhaps we should give up and change ->cread() and friends to return void. That beats the alternative of adding lots of untestable test-n-return unwinding code.
| |