lkml.org 
[lkml]   [2010]   [May]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH 04/12] perf: add @rq to perf_event_task_sched_out()
    From
    Date
    On Tue, 2010-05-04 at 19:22 +0200, Tejun Heo wrote:
    > Hello,
    >
    > On 05/04/2010 07:11 PM, Peter Zijlstra wrote:
    > > On Tue, 2010-05-04 at 14:38 +0200, Tejun Heo wrote:
    > >> Add @rq to perf_event_task_sched_out() so that its argument matches
    > >> those of trace_sched_switch(). This will help unifying notifiers in
    > >> sched.
    > >
    > > The alternative is dropping rq from the trace events, its not like
    > > anybody outside sched.o can do anything sensible with it anyway.
    >
    > The comment in include/trace/events/sched.h says...
    >
    > * (NOTE: the 'rq' argument is not used by generic trace events,
    > * but used by the latency tracer plugin. )
    >
    > So, I left it there. It would be great if all those @rq params can be
    > removed tho. The latency tracer thing needs it, right?

    I believe the rq was used by the original latency tracer code that was
    in the -rt patch set before ftrace. It is most likely there for
    historical purposes. I guess it would be fine to just remove it.

    -- Steve




    \
     
     \ /
      Last update: 2010-05-04 20:25    [from the cache]
    ©2003-2014 Jasper Spaans. Advertise on this site