lkml.org 
[lkml]   [2010]   [May]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 1/4] cpu_stop: implement stop_cpu[s]()
    Hello,

    On 05/03/2010 03:26 PM, Peter Zijlstra wrote:
    > If you do:
    >
    > done = { .ret = -ENOENT, };
    >
    > And remove that if()
    >
    >> + ret = work->fn(work->arg);
    >> + if (ret)
    >> + done->ret = ret;
    >> +
    >
    > You can do away with all the ->executed bits.

    Oh, I had code piece which wanted to discern between -ENOENT from
    non-excution and -ENOENT return from the work function which seems
    gone now. I'll check things again and drop ->executed if everything
    looks okay.

    Thanks.

    --
    tejun


    \
     
     \ /
      Last update: 2010-05-04 08:43    [W:0.113 / U:0.508 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site