Messages in this thread | | | Date | Mon, 31 May 2010 23:27:26 +0200 | From | Frederic Weisbecker <> | Subject | Re: [PATCH] perf-record: Check correct pid when forking |
| |
On Mon, May 31, 2010 at 11:18:18PM +0200, Borislav Petkov wrote: > When forking the child to be traced, we should check the correct return > value from fork() and not a local variable which is otherwise unused. > > Signed-off-by: Borislav Petkov <bp@alien8.de> > --- > tools/perf/builtin-record.c | 3 +-- > 1 files changed, 1 insertions(+), 2 deletions(-) > > diff --git a/tools/perf/builtin-record.c b/tools/perf/builtin-record.c > index 9bc8905..dc3435e 100644 > --- a/tools/perf/builtin-record.c > +++ b/tools/perf/builtin-record.c > @@ -503,7 +503,6 @@ static int __cmd_record(int argc, const char **argv) > { > int i, counter; > struct stat st; > - pid_t pid = 0; > int flags; > int err; > unsigned long waking = 0; > @@ -572,7 +571,7 @@ static int __cmd_record(int argc, const char **argv) > > if (forks) { > child_pid = fork(); > - if (pid < 0) { > + if (child_pid < 0) {
Oops :)
Since I'm preparing some fixes for .35 in perf tools, I'm queuing this one too.
Thanks.
| |