Messages in this thread | | | Date | Mon, 31 May 2010 16:37:17 +0200 | From | Patrick McHardy <> | Subject | Re: [PATCH] netfilter: don't xt_jumpstack_alloc twice in xt_register_table |
| |
Jan Engelhardt wrote: > On Monday 2010-05-31 13:51, Jan Engelhardt wrote: >> On Monday 2010-05-31 13:06, Xiaotian Feng wrote: >> >>> In xt_register_table, xt_jumpstack_alloc is called first, later >>> xt_replace_table is used. But in xt_replace_table, xt_jumpstack_alloc >>> will be used again. Then the memory allocated by previous xt_jumpstack_alloc >>> will be leaked. We can simply remove the previous xt_jumpstack_alloc because >>> there aren't any users of newinfo between xt_jumpstack_alloc and >>> xt_replace_table. >> Indeed that seems to be so. > > Acked-By: Jan Engelhardt <jengelh@medozas.de>
Applied, thanks.
| |